From 7de39c675fa262ba5aef6479775176f4604018f9 Mon Sep 17 00:00:00 2001 From: Krzysztof Nozderko Date: Thu, 28 Nov 2024 14:19:33 +0100 Subject: [PATCH 1/4] SNOW-1833578 support for .net9 --- .github/workflows/main.yml | 9 ++++++--- README.md | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1e1b78850..d19255d52 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -31,7 +31,7 @@ jobs: strategy: fail-fast: false matrix: - dotnet: ['net6.0', 'net7.0', 'net8.0', 'net462', 'net471', 'net472', 'net48', 'net481'] + dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0', 'net462', 'net471', 'net472', 'net48', 'net481'] cloud_env: ['AZURE', 'GCP', 'AWS'] steps: - name: Checkout code @@ -42,6 +42,7 @@ jobs: dotnet-version: | 6.0.x 8.0.x + 9.0.x dotnet-quality: 'ga' - name: Setup Python uses: actions/setup-python@v5 @@ -93,7 +94,7 @@ jobs: strategy: fail-fast: false matrix: - dotnet: ['net6.0', 'net7.0', 'net8.0'] + dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0'] cloud_env: ['AZURE', 'GCP', 'AWS'] steps: - uses: actions/checkout@v4 @@ -103,6 +104,7 @@ jobs: dotnet-version: | 6.0.x 8.0.x + 9.0.x dotnet-quality: 'ga' - name: Setup Python uses: actions/setup-python@v5 @@ -152,7 +154,7 @@ jobs: strategy: fail-fast: false matrix: - dotnet: ['net6.0', 'net7.0', 'net8.0'] + dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0'] cloud_env: ['AZURE', 'GCP', 'AWS'] steps: - uses: actions/checkout@v4 @@ -162,6 +164,7 @@ jobs: dotnet-version: | 6.0.x 8.0.x + 9.0.x dotnet-quality: 'ga' - name: Setup Python uses: actions/setup-python@v5 diff --git a/README.md b/README.md index 682475df3..12e52a056 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![NuGet](https://img.shields.io/nuget/v/Snowflake.Data.svg)](https://www.nuget.org/packages/Snowflake.Data/) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) -The Snowflake .NET connector supports the the following .NET framework and libraries versions: +The Snowflake .NET connector supports the following .NET framework and libraries versions: - .NET Framework 4.6.2 - .NET Framework 4.7.1 @@ -14,6 +14,7 @@ The Snowflake .NET connector supports the the following .NET framework and libra - .NET 6.0 - .NET 7.0 - .NET 8.0 +- .NET 9.0 Disclaimer: While the connector targets netstandard2.0 and may work with versions in its [support matrix](https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version), only the versions listed above are supported and tested by the connector From 94f54f41ef4c36e4c0c4bd5ccce260401bebd30a Mon Sep 17 00:00:00 2001 From: Krzysztof Nozderko Date: Thu, 28 Nov 2024 15:18:01 +0100 Subject: [PATCH 2/4] add net9 to tests --- Snowflake.Data.Tests/Snowflake.Data.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj b/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj index 86da12b20..823421f12 100644 --- a/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj +++ b/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj @@ -1,6 +1,6 @@ - net6.0;net7.0;net8.0;net462;net471;net472;net48;net481 + net6.0;net7.0;net8.0;net9.0;net462;net471;net472;net48;net481 net6.0;net7.0;net8.0; Snowflake.Data.Tests Snowflake Connector for .NET From 122c44dd0d1b45e64bd86a7752c7b8e68742cc91 Mon Sep 17 00:00:00 2001 From: Krzysztof Nozderko Date: Thu, 28 Nov 2024 16:51:55 +0100 Subject: [PATCH 3/4] fix test --- Snowflake.Data.Tests/UnitTests/SFEnvironmentTest.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Snowflake.Data.Tests/UnitTests/SFEnvironmentTest.cs b/Snowflake.Data.Tests/UnitTests/SFEnvironmentTest.cs index 34aa60f2c..ccf352ac8 100644 --- a/Snowflake.Data.Tests/UnitTests/SFEnvironmentTest.cs +++ b/Snowflake.Data.Tests/UnitTests/SFEnvironmentTest.cs @@ -22,6 +22,8 @@ public void TestRuntimeExtraction() expectedVersion = "7.0"; #elif NET8_0 expectedVersion = "8.0"; +#elif NET9_0 + expectedVersion = "9.0"; #endif // Act From b34e2b3d8f22fc68d9e3d5dfb28b20cdd10ca4c5 Mon Sep 17 00:00:00 2001 From: Krzysztof Nozderko Date: Fri, 29 Nov 2024 12:24:49 +0100 Subject: [PATCH 4/4] add missing target --- Snowflake.Data.Tests/Snowflake.Data.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj b/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj index 823421f12..89d295439 100644 --- a/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj +++ b/Snowflake.Data.Tests/Snowflake.Data.Tests.csproj @@ -1,7 +1,7 @@ net6.0;net7.0;net8.0;net9.0;net462;net471;net472;net48;net481 - net6.0;net7.0;net8.0; + net6.0;net7.0;net8.0;net9.0 Snowflake.Data.Tests Snowflake Connector for .NET Snowflake Computing, Inc