-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1276398 Fix not thrown exception when OpenAsync http request fails #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en trying to execute a HTTP request
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1276398-NotThrowException
branch
from
July 30, 2024 00:56
2d0572e
to
a0afc1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
- Coverage 85.63% 85.60% -0.03%
==========================================
Files 106 106
Lines 10777 10777
Branches 1032 1032
==========================================
- Hits 9229 9226 -3
- Misses 1299 1304 +5
+ Partials 249 247 -2 ☔ View full report in Codecov by Sentry. |
sfc-gh-jmartinezramirez
changed the title
Change to throw exception when openasync http request fails.
SNOW-1276398 Fix not thrown exception when OpenAsync http request fails
Jul 30, 2024
sfc-gh-knozderko
previously requested changes
Aug 2, 2024
sfc-gh-pbulawa
approved these changes
Aug 5, 2024
sfc-gh-dstempniak
approved these changes
Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix not thrown exception when OpenAsync http request fails
Checklist
dotnet test
)