Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1276398 Fix not thrown exception when OpenAsync http request fails #999

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented Jul 29, 2024

Description

Fix not thrown exception when OpenAsync http request fails

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1276398-NotThrowException branch from 2d0572e to a0afc1f Compare July 30, 2024 00:56
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (982a1e4) to head (e59c40e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   85.63%   85.60%   -0.03%     
==========================================
  Files         106      106              
  Lines       10777    10777              
  Branches     1032     1032              
==========================================
- Hits         9229     9226       -3     
- Misses       1299     1304       +5     
+ Partials      249      247       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review July 30, 2024 21:27
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner July 30, 2024 21:27
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title Change to throw exception when openasync http request fails. SNOW-1276398 Fix not thrown exception when OpenAsync http request fails Jul 30, 2024
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/HttpUtil.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 288b310 into master Aug 5, 2024
96 of 97 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1276398-NotThrowException branch August 5, 2024 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants