-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1444876: Support for TOML connections #995
Conversation
26060cc
to
9c94717
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 86.15% 86.39% +0.24%
==========================================
Files 120 121 +1
Lines 11648 11779 +131
Branches 1174 1196 +22
==========================================
+ Hits 10035 10177 +142
+ Misses 1330 1319 -11
Partials 283 283 ☔ View full report in Codecov by Sentry. |
f0007af
to
67c5ea8
Compare
db209b0
to
b5762c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation of using toml file configuration is correct. Testing scenarios looks good. One thing, maybe there is a chance to extract some parts of configure test data because of duplications but not very important.
4c36d9c
to
b284fc1
Compare
b284fc1
to
3a59bb6
Compare
3a59bb6
to
7123341
Compare
d5237fc
to
2234c8e
Compare
2234c8e
to
797c124
Compare
Snowflake.Data.Tests/IntegrationTests/SFConnectionWithTomlIT.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionWithTomlIT.cs
Outdated
Show resolved
Hide resolved
8f9e57d
to
98f53b8
Compare
Snowflake.Data.Tests/IntegrationTests/SFConnectionWithTomlIT.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionWithTomlIT.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionWithTomlIT.cs
Outdated
Show resolved
Hide resolved
98f53b8
to
d893c15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check tests that are failing.
063e057
to
47ce801
Compare
c62d728
to
071368d
Compare
071368d
to
b1ab2db
Compare
…r jenkins when is designed to run only locally.
08d40ba
to
615718a
Compare
Description
Support reading configuration from toml configuration file.
Checklist
dotnet test
)