Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1444876: Support for TOML connections #995

Merged
merged 17 commits into from
Nov 7, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented Jul 18, 2024

Description

Support reading configuration from toml configuration file.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch from 26060cc to 9c94717 Compare July 18, 2024 22:57
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title Support for TOML connections SNOW-1444876: Support for TOML connections Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 92.64706% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (4392447) to head (615718a).

Files with missing lines Patch % Lines
Snowflake.Data/Core/TomlConnectionBuilder.cs 95.09% 2 Missing and 3 partials ⚠️
Snowflake.Data/Core/Tools/FileOperations.cs 50.00% 3 Missing and 1 partial ⚠️
Snowflake.Data/Core/Tools/UnixOperations.cs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   86.15%   86.39%   +0.24%     
==========================================
  Files         120      121       +1     
  Lines       11648    11779     +131     
  Branches     1174     1196      +22     
==========================================
+ Hits        10035    10177     +142     
+ Misses       1330     1319      -11     
  Partials      283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch from f0007af to 67c5ea8 Compare July 22, 2024 16:28
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review July 22, 2024 21:18
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner July 22, 2024 21:18
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch from db209b0 to b5762c5 Compare July 24, 2024 14:26
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of using toml file configuration is correct. Testing scenarios looks good. One thing, maybe there is a chance to extract some parts of configure test data because of duplications but not very important.

doc/Connecting.md Outdated Show resolved Hide resolved
doc/Connecting.md Outdated Show resolved Hide resolved
doc/Connecting.md Outdated Show resolved Hide resolved
ci/test.sh Show resolved Hide resolved
doc/Connecting.md Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Tools/UnixOperationsTest.cs Outdated Show resolved Hide resolved
Snowflake.Data/Client/SnowflakeDbConnection.cs Outdated Show resolved Hide resolved
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch 7 times, most recently from 4c36d9c to b284fc1 Compare August 28, 2024 15:57
Snowflake.Data/Core/SnowflakeTomlConnectionBuilder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/SnowflakeTomlConnectionBuilder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/SnowflakeTomlConnectionBuilder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/SnowflakeTomlConnectionBuilder.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Tools/FileOperationsTest.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Tools/UnixOperations.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Tools/UnixOperations.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Tools/FileOperations.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Tools/UnixOperationsTest.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Tools/UnixOperationsTest.cs Outdated Show resolved Hide resolved
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch from b284fc1 to 3a59bb6 Compare August 28, 2024 20:07
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch from 8f9e57d to 98f53b8 Compare October 7, 2024 14:48
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch from 98f53b8 to d893c15 Compare October 8, 2024 15:31
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check tests that are failing.

Snowflake.Data/Core/TomlConnectionBuilder.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/TomlConnectionBuilder.cs Outdated Show resolved Hide resolved
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1444876-TomlConnections branch 2 times, most recently from 063e057 to 47ce801 Compare October 9, 2024 21:16
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez merged commit f27eb2a into master Nov 7, 2024
54 checks passed
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez deleted the SNOW-1444876-TomlConnections branch November 7, 2024 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants