Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1526509 Log connecting area #992

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1526509 Log connecting area

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner July 12, 2024 14:11
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @sfc-gh-knozderko

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (bc329ab) to head (e87cf23).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   85.54%   85.60%   +0.06%     
==========================================
  Files         106      106              
  Lines       10773    10777       +4     
  Branches     1031     1032       +1     
==========================================
+ Hits         9216     9226      +10     
+ Misses       1308     1304       -4     
+ Partials      249      247       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 9736edd into master Jul 15, 2024
52 of 53 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1526509_log_connecting_target branch July 15, 2024 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants