Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1502317: Proposed fix for retrying of nonrecoverable errors #982

Closed
wants to merge 2 commits into from

Conversation

dmarkle
Copy link

@dmarkle dmarkle commented Jun 24, 2024

Description

HttpRequestException with an AuthenticationException is nonrecoverable and should be treated as such. Burying this exception just means we can't tell why our requests are failing.

Checklist

  • [ x] Code compiles correctly
  • [ x] Code is formatted according to Coding Conventions
  • [ x] Created tests which fail without the change (if possible)
  • [ x] All tests passing (dotnet test)
  • [ x] Extended the README / documentation, if necessary
  • [x ] Provide JIRA issue id (if possible) or GitHub issue id in PR name

@dmarkle dmarkle requested a review from a team as a code owner June 24, 2024 18:00
Copy link

github-actions bot commented Jun 24, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dmarkle
Copy link
Author

dmarkle commented Jun 24, 2024

I have read the CLA Document and I hereby sign the CLA

@dmarkle dmarkle changed the title Proposed fix for #981 SNOW-1502317L: Proposed fix for retrying of nonrecoverable errors Jun 24, 2024
@dmarkle dmarkle changed the title SNOW-1502317L: Proposed fix for retrying of nonrecoverable errors SNOW-1502317: Proposed fix for retrying of nonrecoverable errors Jun 24, 2024
@dmarkle
Copy link
Author

dmarkle commented Oct 1, 2024

Withdrawing as this seems fixed in master. Cheers!

@dmarkle dmarkle closed this Oct 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant