Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1473274 Signing assemblies during the release build #977

Closed
wants to merge 2 commits into from

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Jun 14, 2024

Description

SNOW-1473274 Signing assemblies during the release build

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner June 14, 2024 12:21
@sfc-gh-knozderko sfc-gh-knozderko changed the title SNOW-1473274 Revert signing parameters SNOW-1473274 Signing assemblies during the build Jun 14, 2024
@sfc-gh-knozderko sfc-gh-knozderko changed the title SNOW-1473274 Signing assemblies during the build SNOW-1473274 Signing assemblies during the release build Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (1465bda) to head (008f936).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage   85.43%   85.50%   +0.06%     
==========================================
  Files         106      106              
  Lines       10761    10761              
  Branches     1029     1029              
==========================================
+ Hits         9194     9201       +7     
+ Misses       1318     1311       -7     
  Partials      249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants