Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1452613 Update secret detector #961

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1452613 Update secret detector

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner June 5, 2024 09:39
Copy link

gitguardian bot commented Jun 5, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-knozderko sfc-gh-knozderko changed the base branch from master to pool/SNOW-860872-connection-pool June 5, 2024 09:40
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (815f708) to head (6dcab45).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #961      +/-   ##
====================================================================
+ Coverage                             85.38%   85.50%   +0.11%     
====================================================================
  Files                                   106      106              
  Lines                                 10742    10761      +19     
  Branches                               1027     1029       +2     
====================================================================
+ Hits                                   9172     9201      +29     
+ Misses                                 1321     1311      -10     
  Partials                                249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-mhofman sfc-gh-mhofman self-requested a review June 6, 2024 13:05
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sfc-gh-knozderko sfc-gh-knozderko merged commit a4349d7 into pool/SNOW-860872-connection-pool Jun 6, 2024
31 of 32 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1452613_update_secret_detector branch June 6, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants