Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1373257 Make secure password be a part of pool key #942

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented May 13, 2024

Description

SNOW-1373257 Make secure password be a part of pool key

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner May 13, 2024 11:17
Base automatically changed from pool/SNOW-937188-changed-session-behavior to pool/SNOW-860872-connection-pool May 13, 2024 13:20
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-1373257_secure_password_in_pool_key branch from 2f6339a to fb183a4 Compare May 13, 2024 13:26
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (ef2041a) to head (ef2041a).

❗ Current head ef2041a differs from pull request most recent head fb183a4. Consider uploading reports for the commit fb183a4 to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                        @@
##           pool/SNOW-860872-connection-pool     #942   +/-   ##
=================================================================
  Coverage                             85.27%   85.27%           
=================================================================
  Files                                   105      105           
  Lines                                 10606    10606           
  Branches                               1014     1014           
=================================================================
  Hits                                   9044     9044           
  Misses                                 1316     1316           
  Partials                                246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit a9ade08 into pool/SNOW-860872-connection-pool May 14, 2024
19 of 21 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1373257_secure_password_in_pool_key branch May 14, 2024 08:32
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants