-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1373257 Make secure password be a part of pool key #942
Merged
sfc-gh-knozderko
merged 5 commits into
pool/SNOW-860872-connection-pool
from
SNOW-1373257_secure_password_in_pool_key
May 14, 2024
Merged
SNOW-1373257 Make secure password be a part of pool key #942
sfc-gh-knozderko
merged 5 commits into
pool/SNOW-860872-connection-pool
from
SNOW-1373257_secure_password_in_pool_key
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
pool/SNOW-937188-changed-session-behavior
to
pool/SNOW-860872-connection-pool
May 13, 2024 13:20
sfc-gh-knozderko
force-pushed
the
SNOW-1373257_secure_password_in_pool_key
branch
from
May 13, 2024 13:26
2f6339a
to
fb183a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pool/SNOW-860872-connection-pool #942 +/- ##
=================================================================
Coverage 85.27% 85.27%
=================================================================
Files 105 105
Lines 10606 10606
Branches 1014 1014
=================================================================
Hits 9044 9044
Misses 1316 1316
Partials 246 246 ☔ View full report in Codecov by Sentry. |
sfc-gh-mhofman
requested changes
May 13, 2024
…ure_password_in_pool_key
sfc-gh-mhofman
approved these changes
May 13, 2024
sfc-gh-knozderko
merged commit May 14, 2024
a9ade08
into
pool/SNOW-860872-connection-pool
19 of 21 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1373257 Make secure password be a part of pool key
Checklist
dotnet test
)