Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool/SNOW-1337069 pool docs #938

Merged

Conversation

sfc-gh-mhofman
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman commented Apr 30, 2024

Description

New connection pool documentation.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

gitguardian bot commented Apr 30, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-1337069-pool-docs branch from 15dae8f to a0369c0 Compare May 13, 2024 15:31
@sfc-gh-mhofman sfc-gh-mhofman changed the base branch from master to pool/SNOW-860872-connection-pool May 13, 2024 15:42
@sfc-gh-mhofman sfc-gh-mhofman marked this pull request as ready for review May 13, 2024 15:42
@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner May 13, 2024 15:42
README.md Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-1337069-pool-docs branch from 7663d3b to fa11555 Compare May 14, 2024 10:28
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (fe51400) to head (fa11555).

❗ Current head fa11555 differs from pull request most recent head c1204e5. Consider uploading reports for the commit c1204e5 to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #938      +/-   ##
====================================================================
- Coverage                             85.32%   85.28%   -0.05%     
====================================================================
  Files                                   106      106              
  Lines                                 10660    10635      -25     
  Branches                               1023     1019       -4     
====================================================================
- Hits                                   9096     9070      -26     
- Misses                                 1318     1319       +1     
  Partials                                246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko force-pushed the pool/SNOW-860872-connection-pool branch 2 times, most recently from 49d5d13 to 97cceaf Compare May 14, 2024 10:32
README.md Outdated Show resolved Hide resolved
doc/ConnectionPoolingDeprecated.md Show resolved Hide resolved
doc/ConnectionPooling.md Show resolved Hide resolved
doc/ConnectionPooling.md Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
doc/ConnectionPooling.md Outdated Show resolved Hide resolved
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-1337069-pool-docs branch from 793c624 to c1204e5 Compare May 15, 2024 09:51
@sfc-gh-mhofman sfc-gh-mhofman merged commit b2b0ddc into pool/SNOW-860872-connection-pool May 17, 2024
20 of 21 checks passed
@sfc-gh-mhofman sfc-gh-mhofman deleted the pool/SNOW-1337069-pool-docs branch May 17, 2024 08:33
@sfc-gh-mhofman sfc-gh-mhofman restored the pool/SNOW-1337069-pool-docs branch May 17, 2024 08:33
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants