Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool/SNOW-937188 changed session behavior #937

Conversation

sfc-gh-mhofman
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman commented Apr 29, 2024

Description

  • API to switch settings for the new pool
  • API to get pool from the pool manger based on connection string (and if appropriate password)
  • support for pooling or removing a connection when its properties (warehouse, role, db, schema) got altered

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner April 29, 2024 19:05
Copy link

gitguardian bot commented Apr 29, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-mhofman sfc-gh-mhofman changed the base branch from master to pool/SNOW-860872-connection-pool April 29, 2024 19:07
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-937188-changed-session-behavior branch from f74bc2c to 5e4ef69 Compare April 29, 2024 19:40
… session interface SnowflakeDbSessionPool, removal of pool config setters
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-937188-changed-session-behavior branch from 510fa46 to c8320d8 Compare April 30, 2024 11:25
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-937188-changed-session-behavior branch from c8320d8 to a77e6e8 Compare April 30, 2024 12:15
Snowflake.Data/Core/Session/ConnectionCacheManager.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/ConnectionPoolManager.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-937188-changed-session-behavior branch from cedb6cd to 44cfbc4 Compare May 9, 2024 09:59
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-937188-changed-session-behavior branch 3 times, most recently from 456653a to 8ac7f18 Compare May 9, 2024 14:20
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the pool/SNOW-937188-changed-session-behavior branch from 8ac7f18 to 191bacc Compare May 9, 2024 14:26
@sfc-gh-mhofman sfc-gh-mhofman merged commit ef2041a into pool/SNOW-860872-connection-pool May 13, 2024
19 of 21 checks passed
@sfc-gh-mhofman sfc-gh-mhofman deleted the pool/SNOW-937188-changed-session-behavior branch May 13, 2024 13:20
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants