Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1333163: Add support for default proxy configuration #920

Closed
wants to merge 5 commits into from

Conversation

vc-74
Copy link

@vc-74 vc-74 commented Apr 18, 2024

Description

Although the current code supports HTTP proxies, it does not allow to use the default proxy configuration.

This PR allows using the default proxy by specifying the useProxy=true parameter in the connection string without specifying an explicit proxy (proxyHost, proxyPort...).

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test) (I only executed HttpUtilTest to avoid having to configure a connection to Snowflake)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@vc-74 vc-74 requested a review from a team as a code owner April 18, 2024 12:13
Copy link

github-actions bot commented Apr 18, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@vc-74
Copy link
Author

vc-74 commented Apr 18, 2024

I have read the CLA Document and I hereby sign the CLA

@vc-74
Copy link
Author

vc-74 commented Apr 23, 2024

recheck

Snowflake.Data/Snowflake.Data.csproj Outdated Show resolved Hide resolved
Snowflake.Data.Tests/SFBaseTest.cs Outdated Show resolved Hide resolved
@sfc-gh-knozderko
Copy link
Collaborator

Hello @vc-74. Please add here a comment with text: "I have read the CLA Document and I hereby sign the CLA".

I also created a new PR, because I needed to update it and add some new logic: #997

Please review the new PR and add also a comment in it: "I have read the CLA Document and I hereby sign the CLA".

@vc-74 vc-74 closed this by deleting the head repository Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants