Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1313929] Add https to endpoints without it #914

Merged
merged 3 commits into from
Apr 17, 2024
Merged

[SNOW-1313929] Add https to endpoints without it #914

merged 3 commits into from
Apr 17, 2024

Conversation

sfc-gh-erojaslizano
Copy link
Contributor

@sfc-gh-erojaslizano sfc-gh-erojaslizano commented Apr 11, 2024 •
edited
Loading

Description

  • Add https to endpoints without it
  • Add unit test for SetCommonClientConfig

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-erojaslizano sfc-gh-erojaslizano requested a review from a team as a code owner April 11, 2024 14:43
@sfc-gh-erojaslizano
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (aa5b101) to head (e0f2247).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #914   +/-   ##
=======================================
  Coverage   84.64%   84.64%           
=======================================
  Files          89       89           
  Lines        9683     9683           
  Branches      917      917           
=======================================
  Hits         8196     8196           
  Misses       1259     1259           
  Partials      228      228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-jmartinezramirez
sfc-gh-jmartinezramirez approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-erojaslizano sfc-gh-erojaslizano merged commit 47235fb into master Apr 17, 2024
24 checks passed
@sfc-gh-erojaslizano sfc-gh-erojaslizano deleted the SNOW-1313929-append-https-to-url branch April 17, 2024 19:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-erojaslizano @sfc-gh-jmartinezramirez @sfc-gh-knozderko @sfc-gh-mhofman