Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding conventions PR template #905

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Fix coding conventions PR template

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner April 3, 2024 09:51
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the update_coding_conventions_link branch from d9c92d7 to a9bca92 Compare April 3, 2024 09:53
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (ac0860f) to head (a9bca92).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   84.41%   84.34%   -0.08%     
==========================================
  Files          89       89              
  Lines        9683     9683              
  Branches      914      914              
==========================================
- Hits         8174     8167       -7     
- Misses       1274     1282       +8     
+ Partials      235      234       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit a302e0f into master Apr 3, 2024
24 of 25 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the update_coding_conventions_link branch April 3, 2024 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants