Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-921048]Add linter action #892

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

sfc-gh-erojaslizano
Copy link
Contributor

@sfc-gh-erojaslizano sfc-gh-erojaslizano commented Mar 19, 2024

Add linter action

Description

  • Add linter.yml workflow
  • Add .EditorConfig with default rules
  • Add .DS_Store to gitignore

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

github-actions bot commented Mar 19, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the SNOW-921048-check-code-style-wIth-lint branch from 7855e4d to 8f12e55 Compare March 20, 2024 15:29
@sfc-gh-erojaslizano
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the SNOW-921048-check-code-style-wIth-lint branch from 3d869bf to 7477992 Compare April 2, 2024 17:18
@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the SNOW-921048-check-code-style-wIth-lint branch 2 times, most recently from c39b9e1 to d108007 Compare April 10, 2024 16:03
@snowflakedb snowflakedb deleted a comment from codecov bot Apr 10, 2024
@sfc-gh-erojaslizano sfc-gh-erojaslizano changed the title This is a test PR [SNOW-921048]Add linter action Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (aa5b101) to head (e1050ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   84.64%   84.70%   +0.06%     
==========================================
  Files          89       89              
  Lines        9683     9683              
  Branches      917      917              
==========================================
+ Hits         8196     8202       +6     
+ Misses       1259     1253       -6     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

    - Add linter.yml workflow
    - Add .EditorConfig
@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the SNOW-921048-check-code-style-wIth-lint branch from d108007 to 4a7940e Compare April 10, 2024 21:50
@sfc-gh-erojaslizano sfc-gh-erojaslizano marked this pull request as ready for review April 11, 2024 14:43
@sfc-gh-erojaslizano sfc-gh-erojaslizano requested a review from a team as a code owner April 11, 2024 14:43
@sfc-gh-erojaslizano sfc-gh-erojaslizano merged commit 46e496a into master Apr 16, 2024
26 checks passed
@sfc-gh-erojaslizano sfc-gh-erojaslizano deleted the SNOW-921048-check-code-style-wIth-lint branch April 16, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants