Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-825595: Update setup instruction for non-Windows environment #885

Merged

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Update README.md with instructions for building on Non-Windows

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.25%. Comparing base (4d85588) to head (28b6d37).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #885   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files          88       88           
  Lines        9400     9400           
  Branches      886      886           
=======================================
  Hits         7920     7920           
  Misses       1248     1248           
  Partials      232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review March 13, 2024 22:05
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner March 13, 2024 22:05
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit a25f8c5 into master Mar 19, 2024
24 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-825595-Update-Readme-Instructions-NonWindows branch March 19, 2024 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants