Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool/snow-902610 min pool size #880

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Min pool size

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner March 4, 2024 11:19
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the pool/SNOW-902610_min_pool_size branch 4 times, most recently from 771c7ae to 5042245 Compare March 4, 2024 18:40
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 89.10891% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 82.37%. Comparing base (052d895) to head (7bf841b).

Files Patch % Lines
Snowflake.Data/Core/Session/SessionPool.cs 91.54% 5 Missing and 1 partial ⚠️
...flake.Data/Core/Session/SessionOrCreationTokens.cs 82.60% 2 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/SFSession.cs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #880      +/-   ##
====================================================================
+ Coverage                             82.27%   82.37%   +0.09%     
====================================================================
  Files                                   104      104              
  Lines                                  9810     9876      +66     
  Branches                                905      912       +7     
====================================================================
+ Hits                                   8071     8135      +64     
- Misses                                 1489     1491       +2     
  Partials                                250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko force-pushed the pool/SNOW-902610_min_pool_size branch 4 times, most recently from 2777b0b to b81599d Compare March 6, 2024 12:19
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the pool/SNOW-902610_min_pool_size branch from b81599d to 3ad6b97 Compare March 21, 2024 12:01
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the pool/SNOW-902610_min_pool_size branch from 3ad6b97 to 8fa2771 Compare March 25, 2024 08:13
@sfc-gh-knozderko sfc-gh-knozderko merged commit 0983d94 into pool/SNOW-860872-connection-pool Apr 3, 2024
21 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the pool/SNOW-902610_min_pool_size branch April 3, 2024 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants