-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pool/snow-902610 min pool size #880
Merged
sfc-gh-knozderko
merged 7 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW-902610_min_pool_size
Apr 3, 2024
Merged
Pool/snow-902610 min pool size #880
sfc-gh-knozderko
merged 7 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW-902610_min_pool_size
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-knozderko
force-pushed
the
pool/SNOW-902610_min_pool_size
branch
4 times, most recently
from
March 4, 2024 18:40
771c7ae
to
5042245
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pool/SNOW-860872-connection-pool #880 +/- ##
====================================================================
+ Coverage 82.27% 82.37% +0.09%
====================================================================
Files 104 104
Lines 9810 9876 +66
Branches 905 912 +7
====================================================================
+ Hits 8071 8135 +64
- Misses 1489 1491 +2
Partials 250 250 ☔ View full report in Codecov by Sentry. |
sfc-gh-knozderko
force-pushed
the
pool/SNOW-902610_min_pool_size
branch
4 times, most recently
from
March 6, 2024 12:19
2777b0b
to
b81599d
Compare
sfc-gh-knozderko
force-pushed
the
pool/SNOW-902610_min_pool_size
branch
from
March 21, 2024 12:01
b81599d
to
3ad6b97
Compare
sfc-gh-knozderko
force-pushed
the
pool/SNOW-902610_min_pool_size
branch
from
March 25, 2024 08:13
3ad6b97
to
8fa2771
Compare
sfc-gh-mhofman
requested changes
Mar 25, 2024
Snowflake.Data.Tests/IntegrationTests/ConnectionMultiplePoolsIT.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/Session/SessionOrCreationTokensTest.cs
Outdated
Show resolved
Hide resolved
sfc-gh-mhofman
approved these changes
Apr 3, 2024
Snowflake.Data.Tests/IntegrationTests/ConnectionMultiplePoolsIT.cs
Outdated
Show resolved
Hide resolved
sfc-gh-pbulawa
approved these changes
Apr 3, 2024
sfc-gh-knozderko
merged commit Apr 3, 2024
0983d94
into
pool/SNOW-860872-connection-pool
21 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Min pool size
Checklist
dotnet test
)