Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-950923 Flaky test fix #870

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

sfc-gh-mhofman
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman commented Feb 21, 2024

Description

Timeout delta increased to verify Login Request Timeout falls into expected range.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner February 21, 2024 17:42
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d61e81) 84.35% compared to head (12c70e9) 84.21%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   84.35%   84.21%   -0.14%     
==========================================
  Files          88       88              
  Lines        9336     9387      +51     
  Branches      874      883       +9     
==========================================
+ Hits         7875     7905      +30     
- Misses       1235     1251      +16     
- Partials      226      231       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 22871b5 into master Feb 21, 2024
19 of 20 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the FailedTestLoginTimeout branch February 21, 2024 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants