Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-916949: Fix Okta retry for SSO/SAML endpoints #865

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Fix Okta retry for SSO/SAML endpoints

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (9da3d62) 84.11% compared to head (0088e61) 84.45%.

Files Patch % Lines
...flake.Data/Core/Authenticator/OktaAuthenticator.cs 90.10% 4 Missing and 5 partials ⚠️
Snowflake.Data/Core/HttpUtil.cs 54.54% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   84.11%   84.45%   +0.33%     
==========================================
  Files          92       92              
  Lines        9498     9576      +78     
  Branches      879      891      +12     
==========================================
+ Hits         7989     8087      +98     
+ Misses       1283     1260      -23     
- Partials      226      229       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review February 10, 2024 01:08
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner February 10, 2024 01:08
@sfc-gh-pbulawa sfc-gh-pbulawa self-requested a review February 12, 2024 14:11
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit a1f1d6f into master Feb 12, 2024
22 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-916949-Okta-429-Retry branch February 12, 2024 22:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants