Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1009042: Replace Portable.BouncyCastle with BouncyCastle.Cryptography #857

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Jan 31, 2024

Description

Replace unmaintained Portable.BouncyCastle with BouncyCastle.Cryptography.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner January 31, 2024 08:14
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa09941) 83.75% compared to head (1feab77) 83.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   83.75%   83.66%   -0.09%     
==========================================
  Files          89       89              
  Lines        9344     9344              
  Branches      861      861              
==========================================
- Hits         7826     7818       -8     
- Misses       1295     1302       +7     
- Partials      223      224       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-1009042: Upgrade BouncyCastle version to 1.9.0 SNOW-1009042: Replace Portable.BouncyCastle with BouncyCastle.Cryptography Jan 31, 2024
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 80bfb2c into master Feb 8, 2024
21 of 22 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-1010656-bouncycastle-upgrade branch February 8, 2024 09:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants