Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-955536: Multiple SAML Integration #852

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Add multiple SAML Integration

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (7d478f0) 83.93% compared to head (879728c) 83.73%.

Files Patch % Lines
...Core/Authenticator/ExternalBrowserAuthenticator.cs 0.00% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
- Coverage   83.93%   83.73%   -0.21%     
==========================================
  Files          89       89              
  Lines        9313     9344      +31     
  Branches      859      861       +2     
==========================================
+ Hits         7817     7824       +7     
- Misses       1272     1296      +24     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review January 16, 2024 23:45
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner January 16, 2024 23:45
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit fa09941 into master Jan 23, 2024
18 of 20 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-955536-Multiple-SAML-Integration branch January 23, 2024 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants