Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-829779: Strong Name assembly preparation #843

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

These changes are necessary for the Release build with strong name to pass.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner December 22, 2023 15:06
@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-829779-strong-assembly branch from 1ec33cc to 59b4df8 Compare December 22, 2023 15:08
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e12bbb) 83.42% compared to head (59b4df8) 83.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   83.42%   83.49%   +0.06%     
==========================================
  Files          89       89              
  Lines        9189     9189              
  Branches      841      841              
==========================================
+ Hits         7666     7672       +6     
+ Misses       1291     1285       -6     
  Partials      232      232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 1683d66 into master Jan 2, 2024
22 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-829779-strong-assembly branch January 2, 2024 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants