fix dns names with underscore #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bculberson
force-pushed
the
underscore
branch
from
a715a99 to
1055608
Compare
|
Hey, We just encountered this issue in Production. Indeed it seems OpenSSL which is used by the .Net Core runtime implementation doesn't handle well underscores: Would it be possible to have this code released? Thank you! |
|
We are planning to release it in the nearest release. |
sfc-gh-pbulawa
requested changes
Jan 10, 2024
| @@ -260,7 +260,8 @@ internal static SFSessionProperties parseConnectionString(String connectionStrin | |||
| if (!properties.ContainsKey(SFSessionProperty.HOST) || | |||
| (0 == properties[SFSessionProperty.HOST].Length)) | |||
| { | |||
| string hostName = String.Format("{0}.snowflakecomputing.com", properties[SFSessionProperty.ACCOUNT]); | |||
| string compliantAccountName = properties[SFSessionProperty.ACCOUNT].Replace('_','-'); | |||
There was a problem hiding this comment.
We require a possibility to disable the replacement by the parameter in a connection string similar to JDBC to mitigate the risk of privatelink connections not working: Reasoning for JDBC
|
PR #848 implements the feature. Thanks for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DNS names with underscores are not valid in the .net framework. This will construct a working HOST name by replacing with - which is how Snowflake solves for this use case, but users had to manually set HOST.
Checklist
dotnet test)