Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-961434 Fix usage of insecure mode in connection parameters #832

Merged
merged 2 commits into from
Dec 15, 2023
Merged

SNOW-961434 Fix usage of insecure mode in connection parameters #832

merged 2 commits into from
Dec 15, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Dec 13, 2023 •
edited
Loading

Description

SNOW-961434 Fix usage of insecure mode in connection parameters

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner December 13, 2023 12:45
@sfc-gh-knozderko sfc-gh-knozderko changed the title Fix usage of insecure mode in connection parameters SNOW-961434 Fix usage of insecure mode in connection parameters Dec 13, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Dec 13, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (645659a) 83.54% compared to head (659e8b7) 83.49%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.06%     
==========================================
  Files          89       89              
  Lines        9189     9189              
  Branches      841      841              
==========================================
- Hits         7677     7672       -5     
- Misses       1281     1285       +4     
- Partials      231      232       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 49cb77d into master Dec 15, 2023
21 of 22 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-961434_fix_insecure_mod branch December 15, 2023 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jkaluzny sfc-gh-jkaluzny sfc-gh-jkaluzny left review comments

@sfc-gh-dszmolka sfc-gh-dszmolka sfc-gh-dszmolka left review comments

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

@sfc-gh-fochnik sfc-gh-fochnik sfc-gh-fochnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-knozderko @sfc-gh-dszmolka @sfc-gh-jkaluzny @sfc-gh-fochnik @sfc-gh-mhofman