Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-968741: Arrow performance optimizations #831

Merged
merged 13 commits into from
Jan 3, 2024
Merged

SNOW-968741: Arrow performance optimizations #831

merged 13 commits into from
Jan 3, 2024

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Dec 13, 2023 •
edited
Loading

Description

Optimizations for arrow processing.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner December 13, 2023 08:58
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (1683d66) 83.42% compared to head (34332d4) 84.03%.

Files Patch % Lines
Snowflake.Data/Core/ArrowResultSet.cs 78.84% 10 Missing and 1 partial ⚠️
Snowflake.Data/Core/SFResultSet.cs 50.00% 3 Missing ⚠️
Snowflake.Data/Core/ArrowResultChunk.cs 99.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   83.42%   84.03%   +0.60%     
==========================================
  Files          89       89              
  Lines        9189     9293     +104     
  Branches      841      857      +16     
==========================================
+ Hits         7666     7809     +143     
+ Misses       1291     1261      -30     
+ Partials      232      223       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-968741_arrow_perf branch 3 times, most recently from df23ba5 to d2e075b Compare December 20, 2023 14:26
@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team December 22, 2023 08:02
sfc-gh-dstempniak
sfc-gh-dstempniak approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-knozderko
sfc-gh-knozderko reviewed Jan 2, 2024
View reviewed changes
Snowflake.Data/Core/ArrowResultSet.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/ArrowResultChunk.cs Show resolved Hide resolved
Snowflake.Data/Core/BaseResultChunk.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/BaseResultChunk.cs Outdated Show resolved Hide resolved
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit fa1b879 into master Jan 3, 2024
22 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-968741_arrow_perf branch January 3, 2024 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pbulawa @sfc-gh-dstempniak @sfc-gh-knozderko