Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-984600 Avoid closing expired sessions synchronously with obtained lock #830

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Avoid closing sessions synchronously with obtained lock

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner December 11, 2023 09:55
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3710031) 83.54% compared to head (6be094a) 83.49%.

Files Patch % Lines
Snowflake.Data/Core/Session/SFSession.cs 50.00% 0 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/SessionPool.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.06%     
==========================================
  Files          89       89              
  Lines        9188     9189       +1     
  Branches      841      841              
==========================================
- Hits         7676     7672       -4     
- Misses       1281     1285       +4     
- Partials      231      232       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-984600_connect_timeout branch from 9597490 to 8051b51 Compare December 11, 2023 13:05
@sfc-gh-knozderko sfc-gh-knozderko changed the title SNOW-984600 Avoid closing sessions synchronously with obtained lock SNOW-984600 Avoid closing expired sessions synchronously with obtained lock Dec 12, 2023
@sfc-gh-pbulawa sfc-gh-pbulawa self-requested a review December 12, 2023 13:58
@sfc-gh-knozderko sfc-gh-knozderko merged commit 645659a into master Dec 13, 2023
20 of 22 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-984600_connect_timeout branch December 13, 2023 12:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants