-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pool/SNOW-937189 busy sessions in pool (3/4) #818
Merged
sfc-gh-knozderko
merged 3 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW-937189_busy_sessions_in_pool
Nov 28, 2023
Merged
Pool/SNOW-937189 busy sessions in pool (3/4) #818
sfc-gh-knozderko
merged 3 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW-937189_busy_sessions_in_pool
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## pool/SNOW-860872-connection-pool #818 +/- ##
====================================================================
- Coverage 81.58% 81.55% -0.04%
====================================================================
Files 91 93 +2
Lines 9313 9334 +21
Branches 857 858 +1
====================================================================
+ Hits 7598 7612 +14
- Misses 1474 1483 +9
+ Partials 241 239 -2 ☔ View full report in Codecov by Sentry. |
sfc-gh-mhofman
requested changes
Nov 24, 2023
Snowflake.Data.Tests/UnitTests/Session/NonNegativeCounterTest.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/ConnectionSinglePoolCacheIT.cs
Outdated
Show resolved
Hide resolved
sfc-gh-mhofman
approved these changes
Nov 27, 2023
sfc-gh-knozderko
merged commit Nov 28, 2023
56f0b81
into
pool/SNOW-860872-connection-pool
19 of 20 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection Pool v2:
Checklist
dotnet test
)