Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool/SNOW-937189 split pool tests #815

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Split integration tests for different connection pools.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner November 20, 2023 12:38
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af36804) 83.77% compared to head (569c696) 81.50%.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #815      +/-   ##
====================================================================
- Coverage                             83.77%   81.50%   -2.27%     
====================================================================
  Files                                    91       91              
  Lines                                  9313     9313              
  Branches                                857      857              
====================================================================
- Hits                                   7802     7591     -211     
- Misses                                 1279     1482     +203     
- Partials                                232      240       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit bf7a13e into pool/SNOW-860872-connection-pool Nov 20, 2023
19 of 20 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the pool/SNOW-937189_split_pool_tests branch November 20, 2023 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants