pool/SNOW-902608 #2/4 new pool version v2 (#794) #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Connection Pool v2 - introduction of connection manager handling multiple pool of sessions - ability to switch Connection Manager between v1 and v2 - controlling pool settings for each pool independently - default pool version: v1 ### Checklist - [x] Code compiles correctly - [x] Code is formatted according to [Coding Conventions](../CodingConventions.md) - [x] Created tests which fail without the change (if possible) - [x] All tests passing (`dotnet test`) - [x] Extended the README / documentation, if necessary - [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
==========================================
- Coverage 83.56% 81.94% -1.62%
==========================================
Files 89 100 +11
Lines 9155 9589 +434
Branches 837 877 +40
==========================================
+ Hits 7650 7858 +208
- Misses 1278 1486 +208
- Partials 227 245 +18 ☔ View full report in Codecov by Sentry. |
### Description Split integration tests for different connection pools. ### Checklist - [x] Code compiles correctly - [x] Code is formatted according to [Coding Conventions](../CodingConventions.md) - [x] Created tests which fail without the change (if possible) - [x] All tests passing (`dotnet test`) - [x] Extended the README / documentation, if necessary - [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
### Description Connection Pool v2: - introduction of a counter of busy sessions created by Pool Manager - pool size counts both: Idle and Busy sessions ### Checklist - [x] Code compiles correctly - [x] Code is formatted according to [Coding Conventions](../CodingConventions.md) - [x] Created tests which fail without the change (if possible) - [x] All tests passing (`dotnet test`) - [x] Extended the README / documentation, if necessary - [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
### Description SNOW-937190 Wait for idle sessions available if session count exceeds max count ### Checklist - [x] Code compiles correctly - [x] Code is formatted according to [Coding Conventions](../CodingConventions.md) - [x] Created tests which fail without the change (if possible) - [x] All tests passing (`dotnet test`) - [x] Extended the README / documentation, if necessary - [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
|
it's a duplicate |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection Pool v2
Checklist
dotnet test)Description
Please explain the changes you made here.
Checklist
dotnet test)