-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-856231 easy logging - not fail on directory serch error #805
Merged
sfc-gh-knozderko
merged 3 commits into
master
from
SNOW-856231_not_fail_on_finding_files
Oct 30, 2023
Merged
SNOW-856231 easy logging - not fail on directory serch error #805
sfc-gh-knozderko
merged 3 commits into
master
from
SNOW-856231_not_fail_on_finding_files
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
reviewed
Oct 30, 2023
sfc-gh-pfus
reviewed
Oct 30, 2023
Snowflake.Data.Tests/UnitTests/Configuration/EasyLoggingConfigFinderTest.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 83.38% 83.39% +0.01%
==========================================
Files 89 89
Lines 9075 9082 +7
Branches 827 828 +1
==========================================
+ Hits 7567 7574 +7
Misses 1280 1280
Partials 228 228
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-mhofman
requested changes
Oct 30, 2023
Snowflake.Data.Tests/UnitTests/Configuration/EasyLoggingConfigFinderTest.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/Configuration/EasyLoggingConfigFinderTest.cs
Show resolved
Hide resolved
sfc-gh-dstempniak
approved these changes
Oct 30, 2023
sfc-gh-mhofman
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent to fail if client config file could not be found because of an unexpected error during the phase of searching in predefined directory. It could happen if for example there is no home folder in the operating system.
Checklist
dotnet test
)