Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-856231 easy logging - not fail on directory serch error #805

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Oct 30, 2023

Description

Prevent to fail if client config file could not be found because of an unexpected error during the phase of searching in predefined directory. It could happen if for example there is no home folder in the operating system.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner October 30, 2023 11:11
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #805 (34880bc) into master (635b214) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   83.38%   83.39%   +0.01%     
==========================================
  Files          89       89              
  Lines        9075     9082       +7     
  Branches      827      828       +1     
==========================================
+ Hits         7567     7574       +7     
  Misses       1280     1280              
  Partials      228      228              
Files Coverage Δ
...lake.Data/Configuration/EasyLoggingConfigFinder.cs 100.00% <100.00%> (+9.09%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-knozderko sfc-gh-knozderko merged commit eb2e0ab into master Oct 30, 2023
20 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-856231_not_fail_on_finding_files branch October 30, 2023 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants