SNOW-878067: Retry Strategy #803

sfc-gh-ext-simba-lf · 2023-10-26T23:02:06Z

Description

Regarding issue 575

The PR adds a new retry strategy for login requests with a new base time and adding jitter. It also adds the id and name to the header for login requests

New parameters for retry strategy

RETRY_TIMEOUT: retry timeout in seconds. defaults to 300 and can only be increased

Modified parameters

CONNECTION_TIMEOUT: changed default from 120 to 300

Checklist

Code compiles correctly
Code is formatted according to Coding Conventions
Created tests which fail without the change (if possible)
All tests passing (dotnet test)
Extended the README / documentation, if necessary
Provide JIRA issue id (if possible) or GitHub issue id in PR name

…nector-net into SNOW-878067-Retry-Strategy

codecov · 2023-10-26T23:32:21Z

Codecov Report

Merging #803 (4cc94f7) into master (635b214) will decrease coverage by 0.31%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
- Coverage   83.38%   83.07%   -0.31%     
==========================================
  Files          89       89              
  Lines        9075     9148      +73     
  Branches      827      835       +8     
==========================================
+ Hits         7567     7600      +33     
- Misses       1280     1323      +43     
+ Partials      228      225       -3

Files	Coverage Δ
Snowflake.Data/Core/HttpUtil.cs	`94.08% <100.00%> (-2.42%)`	⬇️
Snowflake.Data/Core/RestRequest.cs	`89.02% <100.00%> (+0.41%)`	⬆️
Snowflake.Data/Core/Session/SFSession.cs	`79.41% <100.00%> (+0.10%)`	⬆️
...Data/Core/Session/SFSessionHttpClientProperties.cs	`94.73% <100.00%> (+2.28%)`	⬆️
Snowflake.Data/Core/Session/SFSessionProperty.cs	`82.08% <ø> (ø)`

... and 13 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

…nector-net into SNOW-878067-Retry-Strategy

Snowflake.Data/Core/Session/SFSessionProperty.cs

Snowflake.Data/Core/HttpUtil.cs

Snowflake.Data.Tests/UnitTests/HttpUtilTest.cs

…lakedb/snowflake-connector-net into SNOW-878067-Retry-Strategy

Snowflake.Data/Core/HttpUtil.cs

Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs

Snowflake.Data.Tests/IntegrationTests/SFDbCommandIT.cs

codecov · 2023-11-03T18:49:12Z

Codecov Report

Merging #803 (4cc94f7) into master (635b214) will decrease coverage by 0.31%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
- Coverage   83.38%   83.07%   -0.31%     
==========================================
  Files          89       89              
  Lines        9075     9148      +73     
  Branches      827      835       +8     
==========================================
+ Hits         7567     7600      +33     
- Misses       1280     1323      +43     
+ Partials      228      225       -3

Files	Coverage Δ
Snowflake.Data/Core/HttpUtil.cs	`94.08% <100.00%> (-2.42%)`	⬇️
Snowflake.Data/Core/RestRequest.cs	`89.02% <100.00%> (+0.41%)`	⬆️
Snowflake.Data/Core/Session/SFSession.cs	`79.41% <100.00%> (+0.10%)`	⬆️
...Data/Core/Session/SFSessionHttpClientProperties.cs	`94.73% <100.00%> (+2.28%)`	⬆️
Snowflake.Data/Core/Session/SFSessionProperty.cs	`82.08% <ø> (ø)`

... and 13 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov · 2023-11-03T18:49:27Z

Codecov Report

Merging #803 (4cc94f7) into master (635b214) will increase coverage by 0.28%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   83.38%   83.67%   +0.28%     
==========================================
  Files          89       89              
  Lines        9075     9149      +74     
  Branches      827      835       +8     
==========================================
+ Hits         7567     7655      +88     
+ Misses       1280     1268      -12     
+ Partials      228      226       -2

Files	Coverage Δ
Snowflake.Data/Core/HttpUtil.cs	`96.88% <100.00%> (+0.39%)`	⬆️
Snowflake.Data/Core/RestRequest.cs	`89.02% <100.00%> (+0.41%)`	⬆️
Snowflake.Data/Core/Session/SFSession.cs	`81.00% <100.00%> (+1.69%)`	⬆️
...Data/Core/Session/SFSessionHttpClientProperties.cs	`94.73% <100.00%> (+2.28%)`	⬆️
Snowflake.Data/Core/Session/SFSessionProperty.cs	`82.08% <ø> (ø)`

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov · 2023-11-03T18:49:38Z

Codecov Report

Merging #803 (4f511f4) into master (635b214) will increase coverage by 0.16%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   83.38%   83.54%   +0.16%     
==========================================
  Files          89       89              
  Lines        9075     9146      +71     
  Branches      827      835       +8     
==========================================
+ Hits         7567     7641      +74     
+ Misses       1280     1278       -2     
+ Partials      228      227       -1

Files	Coverage Δ
Snowflake.Data/Core/HttpUtil.cs	`96.82% <100.00%> (+0.33%)`	⬆️
Snowflake.Data/Core/RestRequest.cs	`89.02% <100.00%> (+0.41%)`	⬆️
Snowflake.Data/Core/Session/SFSession.cs	`79.41% <100.00%> (+0.10%)`	⬆️
...Data/Core/Session/SFSessionHttpClientProperties.cs	`94.93% <100.00%> (+2.48%)`	⬆️
Snowflake.Data/Core/Session/SFSessionProperty.cs	`82.08% <ø> (ø)`

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Snowflake.Data/Core/HttpUtil.cs

sfc-gh-dstempniak

LGTM, please remember about (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))

sfc-gh-ext-simba-lf · 2023-11-03T20:06:23Z

LGTM, please remember about (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))

The OS check is now removed

ghost

LGTM

sfc-gh-ext-simba-lf added 4 commits October 26, 2023 11:12

SNOW-878067: Add retry strategy for supported endpoints

68e4dc1

SNOW-878067: Add tests for retry strategy

b7dc6bd

Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…

59f1f7e

…nector-net into SNOW-878067-Retry-Strategy

SNOW-878067: Fix variable name

5d7f9e1

sfc-gh-ext-simba-lf added 3 commits October 26, 2023 16:36

SNOW-878067: Increase delta for async timeout test

77611e6

SNOW-878067: Increase delta for async timeout test

9639f43

SNOW-878067: Increase delta for timeout test

a441122

sfc-gh-ext-simba-lf requested a review from sfc-gh-dstempniak October 26, 2023 23:57

sfc-gh-ext-simba-lf marked this pull request as ready for review October 26, 2023 23:58

sfc-gh-ext-simba-lf requested a review from a team as a code owner October 26, 2023 23:58

sfc-gh-ext-simba-lf added 3 commits October 26, 2023 17:38

SNOW-878067: Refactor variable for connection timeout

ddd961e

SNOW-878067: Refactor variable for connection timeout

a203e19

Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…

949c257

…nector-net into SNOW-878067-Retry-Strategy

sfc-gh-ext-simba-lf requested a review from sfc-gh-mhofman October 27, 2023 15:14

sfc-gh-dstempniak requested changes Oct 31, 2023

View reviewed changes

Snowflake.Data/Core/Session/SFSessionProperty.cs Show resolved Hide resolved

Snowflake.Data/Core/HttpUtil.cs Outdated Show resolved Hide resolved

Snowflake.Data/Core/HttpUtil.cs Outdated Show resolved Hide resolved

Snowflake.Data.Tests/UnitTests/HttpUtilTest.cs Show resolved Hide resolved

sfc-gh-ext-simba-lf and others added 10 commits October 31, 2023 12:12

Update CONNECTION_TIMEOUT default value from 120 to 300

da0d1c6

SNOW-878067: Update retry logic

8007e5e

Update README.md with new parameter "RETRY_TIMEOUT"

5b926b7

SNOW-878067: Modify timeout test cases

2866dec

Merge branch 'SNOW-878067-Retry-Strategy' of https://github.com/snowf…

692bb36

…lakedb/snowflake-connector-net into SNOW-878067-Retry-Strategy

SNOW-878067: Modify timeout test cases

d0a445e

SNOW-878067: Modify timeout test cases

ce6b2b6

SNOW-878067: Modify timeout test cases

98f0abe

SNOW-878067: Update comment

b25afec

SNOW-878067: Modify timeout test cases

13fa45f

sfc-gh-dstempniak reviewed Nov 3, 2023

View reviewed changes

sfc-gh-ext-simba-lf added 2 commits November 3, 2023 11:15

SNOW-878067: Refactor retry logic

5e9931e

SNOW-878067: Set maxHttpRetries to 0 to reach the defined timeout

4cc94f7

ghost reviewed Nov 3, 2023

View reviewed changes

Snowflake.Data/Core/HttpUtil.cs Outdated Show resolved Hide resolved

sfc-gh-dstempniak approved these changes Nov 3, 2023

View reviewed changes

SNOW-878067: Remove OS Platform restriction on timeout tests

ef12cef

SNOW-878067: Refactor setting which timeout to use

4f511f4

ghost approved these changes Nov 6, 2023

View reviewed changes

sfc-gh-ext-simba-lf merged commit 7f73791 into master Nov 6, 2023
19 of 20 checks passed

sfc-gh-ext-simba-lf deleted the SNOW-878067-Retry-Strategy branch November 6, 2023 18:06

github-actions bot locked and limited conversation to collaborators Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SNOW-878067: Retry Strategy #803

SNOW-878067: Retry Strategy #803

sfc-gh-ext-simba-lf commented Oct 26, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading

codecov bot commented Nov 3, 2023

codecov bot commented Nov 3, 2023 •

edited

Loading

codecov bot commented Nov 3, 2023 •

edited

Loading

sfc-gh-dstempniak left a comment

sfc-gh-ext-simba-lf commented Nov 3, 2023

ghost left a comment

SNOW-878067: Retry Strategy #803

SNOW-878067: Retry Strategy #803

Conversation

sfc-gh-ext-simba-lf commented Oct 26, 2023 • edited Loading

Description

Checklist

codecov bot commented Oct 26, 2023 • edited Loading

Codecov Report

codecov bot commented Nov 3, 2023

Codecov Report

codecov bot commented Nov 3, 2023 • edited Loading

Codecov Report

codecov bot commented Nov 3, 2023 • edited Loading

Codecov Report

sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

sfc-gh-ext-simba-lf commented Nov 3, 2023

ghost left a comment

Choose a reason for hiding this comment

sfc-gh-ext-simba-lf commented Oct 26, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading

codecov bot commented Nov 3, 2023 •

edited

Loading

codecov bot commented Nov 3, 2023 •

edited

Loading