pool/SNOW-902611 #1/4 removed singleton pattern from SessionPool; introduced ne… #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mhofman
commented
Oct 11, 2023
sfc-gh-mhofman
commented
Oct 11, 2023
…w interface for ConnectionManager; split tests of ConnectionPool and some cleanup in the classes
sfc-gh-mhofman
force-pushed
the
pool/SNOW-902611-new-pool-lifecycle
branch
from
ca04c5b to
ceef6c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 84.95% 84.86% -0.10%
==========================================
Files 89 90 +1
Lines 8719 8739 +20
==========================================
+ Hits 7407 7416 +9
- Misses 1312 1323 +11
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-mhofman
changed the title
sfc-gh-mhofman
changed the title
Snowflake.Data.Tests/IntegrationTests/SFConnectionPoolAsyncIT.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionPoolAsyncIT.cs
Outdated
Show resolved
Hide resolved
sfc-gh-knozderko
approved these changes
Oct 13, 2023
sfc-gh-mhofman
force-pushed
the
pool/SNOW-902611-new-pool-lifecycle
branch
from
969b964 to
ed7d989
Compare
sfc-gh-mhofman
force-pushed
the
pool/SNOW-902611-new-pool-lifecycle
branch
from
ed7d989 to
bcee106
Compare
sfc-gh-dstempniak
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection Pool v1
-Removal of singleton pattern from SessionPool
-Introduction of interface and an its implementation of ConnectionManager
-Split integration tests of ConnectionPool (into separate files) + some cleanup in the classes
Checklist
dotnet test)