Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-929914 Update README.md with example how to bind an array as variable #782

Closed
wants to merge 2 commits into from

Conversation

sfc-gh-dszmolka
Copy link
Contributor

Co-authored-by: @sfc-gh-hachouraria

README.md Outdated

var p1 = cmd.CreateParameter();
p1.ParameterName = "1";
p1.Value = array; // passing the array in the bind variable
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple array would do as well: https://github.com/snowflakedb/snowflake-connector-net/blob/master/Snowflake.Data.Tests/IntegrationTests/SFBindTestIT.cs#L567
Should we mention about it since it doesn't require dependency nor formatting to a JSON string?

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (6feb3cb) to head (953f045).
Report is 62 commits behind head on master.

❗ Current head 953f045 differs from pull request most recent head c7bfcc5. Consider uploading reports for the commit c7bfcc5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   84.99%   84.92%   -0.07%     
==========================================
  Files          89       89              
  Lines        8677     8677              
==========================================
- Hits         7375     7369       -6     
- Misses       1302     1308       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-929914-document-binding-an-array branch April 8, 2024 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants