Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Asynchronous Queries Interface #378

Closed
Coder3333 opened this issue Sep 24, 2021 · 8 comments
Closed

Request for Asynchronous Queries Interface #378

Coder3333 opened this issue Sep 24, 2021 · 8 comments
Assignees
Labels
enhancement The issue is a request for improvement or a new feature status-in_progress Issue is worked on by the driver team status-triage_done Initial triage done, will be further handled by the driver team

Comments

@Coder3333
Copy link

The python sdk gives the option to start an asynchronous query directly and then use the query id to manually request the results. It looks like this would be a simple feature to add to the .Net sdk given the current code base. It could just be a new method added to SnowflakeDbCommand. Are there plans to add asynchronous queries to the .Net sdk in the near future?

https://docs.snowflake.com/en/user-guide/python-connector-example.html#label-python-connector-asynchronous-query-examples

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi added the enhancement The issue is a request for improvement or a new feature label Oct 14, 2021
@Coder3333
Copy link
Author

I am really close to getting this to work, but I am having trouble with the last piece of the puzzle (how to get the status of the query). Can I get a hand?

This is my branch with the work so far. Look for SnowflakeDbAsynchronousQueryHelper:
https://github.com/Coder3333/snowflake-connector-net/tree/AddAsync

Stackoverflow post asking how to get query status:
https://stackoverflow.com/questions/70803863/how-to-get-execution-status-of-asynchronous-snowflake-query-by-query-id

@Coder3333
Copy link
Author

I created this pull request with my effort to bring asynchronous queries to the .Net Connector

#421

@sfc-gh-jfan sfc-gh-jfan reopened this Jul 1, 2022
@github-actions github-actions bot closed this as completed Jul 2, 2022
@sfc-gh-jfan sfc-gh-jfan reopened this Jul 6, 2022
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage Issue is under initial triage label Jun 7, 2023
@sfc-gh-dszmolka
Copy link
Contributor

hi and thank you for submitting this issue , apologies for the long period without response. also thank you for sending the PR !
checked this repo and async api already seems to be available in recent versions of the driver since #510 , thus marking this issue as closed.

@sfc-gh-dszmolka sfc-gh-dszmolka removed the status-triage Issue is under initial triage label Jun 7, 2023
@Coder3333
Copy link
Author

hi and thank you for submitting this issue , apologies for the long period without response. also thank you for sending the PR ! checked this repo and async api already seems to be available in recent versions of the driver since #510 , thus marking this issue as closed.

@sfc-gh-dszmolka , Please, reopen this issue, as it has not been addressed. The issue that you referenced is simply a .Net way to make it easier to run multi-threaded code, locally. My request, and the PR, address the Snowflake Server side feature of starting a Snowflake query at the server, getting back a query id, and then being able to check on the status of the query with the id. The Python and Java clients have supported this feature all along. It is very sad that the .Net client still does not.

@sfc-gh-dszmolka
Copy link
Contributor

thank you for the explanation here, I was under the impression the async API is already available but apparently not fully. Anyways, we'll take a look.

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-in_progress Issue is worked on by the driver team label Jun 8, 2023
@Coder3333
Copy link
Author

It is very disheartening that I provided a solution to this issue a year ago, and because it was ignored and the base code continued to change over that time, all of that work has to be scrapped and a new solution would need to be built. The java and python clients have had this feature for years. Why has it not be prioritized for .Net?

@sfc-gh-dszmolka
Copy link
Contributor

I don't have an answer for that and completely understand the disappointment here, which is quite rightful and I'm sorry you feel this way.
I cannot account for the past, but I hope it's at least some kind of consolation that going forward (as seen in the other Snowflake open source driver repos as well) we're trying to address the mistakes from the past and provide more effort and resources for the open source repos and community.

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage_done Initial triage done, will be further handled by the driver team label Mar 12, 2024
@sfc-gh-dszmolka
Copy link
Contributor

this has been implemented and released with the latest version of the .NET driver 3.1.0
closing this issue and thank you for bearing with us !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is a request for improvement or a new feature status-in_progress Issue is worked on by the driver team status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

7 participants