Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1789757 Support GCP region specific endpoint #1064

Merged

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1789757 Support GCP region specific endpoint

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner November 28, 2024 12:39
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.32%. Comparing base (d212fc7) to head (ded25c2).

Files with missing lines Patch % Lines
...ata/Core/FileTransfer/StorageClient/SFGCSClient.cs 80.64% 5 Missing and 1 partial ⚠️
Snowflake.Data/Core/RestResponse.cs 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   86.31%   86.32%   +0.01%     
==========================================
  Files         121      121              
  Lines       11785    11821      +36     
  Branches     1197     1205       +8     
==========================================
+ Hits        10172    10205      +33     
  Misses       1329     1329              
- Partials      284      287       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 6d0ba1f into master Nov 29, 2024
53 of 54 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1789757_support_gcp_region_specific_endpoint branch November 29, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants