-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SnowflakeDbDataReader implementation of GetEnumerator using DbEnumerator class #1031
Merged
sfc-gh-jmartinezramirez
merged 3 commits into
master
from
SNOW-1694693-SupportGetEnumerator
Oct 8, 2024
Merged
Added SnowflakeDbDataReader implementation of GetEnumerator using DbEnumerator class #1031
sfc-gh-jmartinezramirez
merged 3 commits into
master
from
SNOW-1694693-SupportGetEnumerator
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
==========================================
+ Coverage 85.86% 85.89% +0.02%
==========================================
Files 118 118
Lines 11456 11455 -1
Branches 1146 1146
==========================================
+ Hits 9837 9839 +2
+ Misses 1335 1333 -2
+ Partials 284 283 -1 ☔ View full report in Codecov by Sentry. |
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1694693-SupportGetEnumerator
branch
from
October 3, 2024 21:16
fcaf4c8
to
5e397db
Compare
sfc-gh-jmartinezramirez
changed the title
Added implementation of GetEnumerator using DbEnumerator class
Added SnowflakeDbDataReader implementation of GetEnumerator using DbEnumerator class
Oct 4, 2024
sfc-gh-knozderko
requested changes
Oct 4, 2024
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1694693-SupportGetEnumerator
branch
from
October 4, 2024 17:05
5e397db
to
bcf33ba
Compare
sfc-gh-knozderko
requested changes
Oct 7, 2024
Snowflake.Data.Tests/IntegrationTests/SFDbDataReaderGetEnumeratorIT.cs
Outdated
Show resolved
Hide resolved
sfc-gh-knozderko
approved these changes
Oct 7, 2024
sfc-gh-pbulawa
approved these changes
Oct 8, 2024
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1694693-SupportGetEnumerator
branch
from
October 8, 2024 15:04
4e73320
to
408dc90
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added implementation of GetEnumerator using DbEnumerator class.
Checklist
dotnet test
)