Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SnowflakeDbDataReader implementation of GetEnumerator using DbEnumerator class #1031

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented Sep 27, 2024

Description

Added implementation of GetEnumerator using DbEnumerator class.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (3d0194c) to head (408dc90).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
+ Coverage   85.86%   85.89%   +0.02%     
==========================================
  Files         118      118              
  Lines       11456    11455       -1     
  Branches     1146     1146              
==========================================
+ Hits         9837     9839       +2     
+ Misses       1335     1333       -2     
+ Partials      284      283       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review September 27, 2024 23:12
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner September 27, 2024 23:12
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1694693-SupportGetEnumerator branch from fcaf4c8 to 5e397db Compare October 3, 2024 21:16
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title Added implementation of GetEnumerator using DbEnumerator class Added SnowflakeDbDataReader implementation of GetEnumerator using DbEnumerator class Oct 4, 2024
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1694693-SupportGetEnumerator branch from 5e397db to bcf33ba Compare October 4, 2024 17:05
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1694693-SupportGetEnumerator branch from 4e73320 to 408dc90 Compare October 8, 2024 15:04
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez enabled auto-merge (squash) October 8, 2024 15:05
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez merged commit ef6db7e into master Oct 8, 2024
49 of 50 checks passed
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez deleted the SNOW-1694693-SupportGetEnumerator branch October 8, 2024 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants