Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1640968 chunk downloader fix #1022

Merged
merged 10 commits into from
Oct 9, 2024
Merged

SNOW-1640968 chunk downloader fix #1022

merged 10 commits into from
Oct 9, 2024

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

Description

Clearing memory after chunk download.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner September 6, 2024 12:10
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.68508% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.86%. Comparing base (ef6db7e) to head (0f8ba07).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 95.83% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   85.87%   85.86%   -0.01%     
==========================================
  Files         118      118              
  Lines       11455    11486      +31     
  Branches     1146     1148       +2     
==========================================
+ Hits         9837     9863      +26     
- Misses       1333     1340       +7     
+ Partials      285      283       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Sep 11, 2024
Closed
@sfc-gh-dstempniak
Merge remote-tracking branch 'origin/master' into SNOW-1640968-chunk_…
b65f915 
…downloader_fix

# Conflicts:
#	Snowflake.Data/Core/ArrowResultChunk.cs
#	Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs
@sfc-gh-dstempniak
SNOW-1640968 revert metaBlockLengthBits
b411e88
@sfc-gh-dstempniak
SNOW-1640968 fix after merge
6f4620a
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 950fa55 into master Oct 9, 2024
52 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1640968-chunk_downloader_fix branch October 9, 2024 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dstempniak @sfc-gh-pbulawa @sfc-gh-knozderko