Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1636484 document certificate checking in .NET driver #1015

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

sfc-gh-dszmolka
Copy link
Contributor

Description

This is a documentation-only change, describing how certificate validation works today in .NET driver as opposed to all the other Snowflake drivers, and describing some possible gotchas to pay attention for.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (c3cb344) to head (738741e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
- Coverage   85.70%   85.66%   -0.04%     
==========================================
  Files         117      117              
  Lines       11331    11331              
  Branches     1130     1130              
==========================================
- Hits         9711     9707       -4     
- Misses       1342     1345       +3     
- Partials      278      279       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team September 5, 2024 07:42
@sfc-gh-dszmolka sfc-gh-dszmolka merged commit caace83 into master Sep 16, 2024
53 of 54 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-1636484-document-CRL branch September 16, 2024 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants