Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1640968 Make connection finaliser a not blocking operation #1009

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Aug 21, 2024

Description

SNOW-1640968 Make connection finaliser a not blocking operation to avoid blocking garbage collector which could lead to massive memory consumption.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner August 21, 2024 14:22
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.56%. Comparing base (3707fa0) to head (af4daf7).

Files Patch % Lines
Snowflake.Data/Core/Session/SFSession.cs 94.44% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   85.61%   85.56%   -0.06%     
==========================================
  Files         106      106              
  Lines       10777    10788      +11     
  Branches     1032     1033       +1     
==========================================
+ Hits         9227     9231       +4     
- Misses       1303     1310       +7     
  Partials      247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SFSession.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko changed the title SNOW-1612981 Make connection finalizer a not blocking operation SNOW-1640968 Make connection finaliser a not blocking operation Aug 27, 2024
@sfc-gh-knozderko sfc-gh-knozderko merged commit 7e67f65 into master Aug 27, 2024
53 of 54 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1612981_not_blocking_finalizer branch August 27, 2024 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants