-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1640968 Make connection finaliser a not blocking operation #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 85.61% 85.56% -0.06%
==========================================
Files 106 106
Lines 10777 10788 +11
Branches 1032 1033 +1
==========================================
+ Hits 9227 9231 +4
- Misses 1303 1310 +7
Partials 247 247 ☔ View full report in Codecov by Sentry. |
sfc-gh-mhofman
requested changes
Aug 22, 2024
sfc-gh-knozderko
changed the title
SNOW-1612981 Make connection finalizer a not blocking operation
SNOW-1640968 Make connection finaliser a not blocking operation
Aug 27, 2024
sfc-gh-mhofman
approved these changes
Aug 27, 2024
sfc-gh-pbulawa
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1640968 Make connection finaliser a not blocking operation to avoid blocking garbage collector which could lead to massive memory consumption.
Checklist
dotnet test
)