Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1637718: disable IMDS when creating AWS client #741

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

sfc-gh-ext-simba-hx
Copy link
Collaborator

teamwork issue 1089
disable IMDS (attempt to accessing EC2 metadata service) as it's not really needed.
No automation test case added but checked manually through log that no attempt against 169.254.169.254 anymore with this change.

Copy link
Contributor

@sfc-gh-dstempniak sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-hx
Copy link
Collaborator Author

@sfc-gh-pbulawa Please review we need 2 approval to merge the PR. cc @sfc-gh-dstempniak

@sfc-gh-dstempniak sfc-gh-dstempniak merged commit cdf83bc into master Aug 27, 2024
43 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1637718-disable-EC2-metadata-service branch August 27, 2024 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants