SNOW-983098: redo arrow update 15.0.0 #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
SNOW-983098-redo-arrow-update-15.0.0
branch
from
e6a0e84 to
7b25a64
Compare
ghost
marked this pull request as draft
|
The SEGFAULT with Mac debug build is related to static regex defined in https://github.com/snowflakedb/libsnowflakeclient/blob/master/cpp/logger/SecretDetector.cpp when calling ~mem_block_cache at the ending of test application. Will get that fixed before asking for review. |
ghost
marked this pull request as ready for review
ghost
requested review from
sfc-gh-dprzybysz
and removed request for
sfc-gh-dprzybysz
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
|
Confirmed no performance issue with adding |
sfc-gh-dprzybysz
approved these changes
Apr 23, 2024
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teamwork issue 780
temporarily add build number in libsnowflakeclient version to avoid replacing artifacts on s3 built with gcc5. Will remove when ODBC also move to gcc8.