Snow 348856 xp regress revert lastknown version centos7 builds #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SNOW-301717 Libsnowflakeclient build for XP * Add a flag to disable certain pieces of code for XP * Add gcc82 to list of compilers that can be picked up * Macro the pieces that XP does not use with the defined flag Description Testing * Pass build source only options to build scripts to turn off building tests
* fix centos 7 compiler errors with strncpy * using sb_strcpy instead of strcpy
…301) SNOW-301714 prevent mixing up of XP artifacts with ODBC SNOW-301727 upload xp artifacts to a different stage Description Libsnowflakeclient for XP built using gcc/g++82 compiler toolchain Testing For ODBC tested on Jenkins and Github actions XP build will be tested separately
sfc-gh-vreddy
changed the base branch from
master
to
SNOW-348856-xp-regress-revert-lastknown-version
sfc-gh-vreddy
changed the base branch from
SNOW-348856-xp-regress-revert-lastknown-version
to
master
sfc-gh-vreddy
changed the base branch from
master
to
SNOW-348856-xp-regress-revert-lastknown-version
Description Testing
Description Testing
…l-logger SNOW-176219 augmenting external logger to be used for every log line
In rare occasions LibSfClient complains that the received response from GS does not contain query code (which is set null for success and the corresponding error code in case of failure). With this task we want to log response in such case
Add more logs in snowflake_execute and snowflake_prepare function
Snowhouse has the limitation of the log message size. Therefore, we need to keep the useful information and delete inessential attributes in response json.
1. Add log around the curl_easy_perform function because this is a function that may cause the query stuck in libsfclient, we should add log in advance so when the issue happens again, we could direct check it. 2. Delete some useless logs, it should be my fault, I made a small mistake in the curl_get_call and curl_post_call, the outside do while loop, the condition is while(0) so it will not cause an infinite loop here.
This PR is the exact equivalent of #37217. In that PR the changes were done in ported version of LibSfClient and in this one are copied over to the open source version.
align with ported libsfclient
…d of resetting Description Testing
Description Testing
Description Testing
SNOW-492015 adding init_snowflake_error
|
libsnowflakeclient is not necessary in XP anymore - we can close it |
sfc-gh-dprzybysz
deleted the
SNOW-348856-xp-regress-revert-lastknown-version-centos7-builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not Merge
This branch is currently used by XP to build libsnowflakeclient.
The master has Arrow and JSON result set refactoring which is not yet tested. So the XP team continues to use this branch for a while until the master is tested.