Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-348856 XP regression revert to last known working commit #311

Closed

Conversation

sfc-gh-vreddy
Copy link
Contributor

Picked up the commit used for the last XP build.
Cherry picked Sabers changes

sfc-gh-zli and others added 5 commits March 16, 2021 20:09
Update dev procedure for libsnowflakeclient

Update dev procedure for libsnowflakeclient
…t otherwise the query is silently skipped (SUCCESS is returned) (#309)

Description

Testing

Co-authored-by: saber mirzaei <[email protected]>
@sfc-gh-vreddy sfc-gh-vreddy requested a review from a team as a code owner April 23, 2021 22:10
@sfc-gh-vreddy sfc-gh-vreddy force-pushed the SNOW-348856-xp-regress-revert-lastknown-version branch from 3a41aaf to 4559792 Compare April 30, 2021 16:19
@sfc-gh-smirzaei
Copy link
Collaborator

@sfc-gh-vreddy I thought we were going to used this branch for that PC issue. Are we using this branch for anything else? whaat are the new commits about?

@sfc-gh-vreddy
Copy link
Contributor Author

@sfc-gh-smirzaei These commits are in the scripts mostly to make them compilable on centos 7.
As part of making libsnowflakeclient compilable on centos 7 from XP i am using this branch.

@sfc-gh-vreddy sfc-gh-vreddy force-pushed the SNOW-348856-xp-regress-revert-lastknown-version branch from 4559792 to 062a85a Compare April 30, 2021 23:26
@sfc-gh-vreddy sfc-gh-vreddy marked this pull request as draft May 18, 2021 17:56
@sfc-gh-dprzybysz
Copy link
Collaborator

It's old PR with a lot of conflicts and the code here in this repo does not influence XP anymore

@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-348856-xp-regress-revert-lastknown-version branch May 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants