Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of circular dependencies #406

Open
KonradHoeffner opened this issue Oct 26, 2023 · 2 comments
Open

get rid of circular dependencies #406

KonradHoeffner opened this issue Oct 26, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@KonradHoeffner
Copy link
Collaborator

KonradHoeffner commented Oct 26, 2023

Dependency cycles (circular dependencies) in the inputs may cause problematic behavior, such as freezing of vitest #407.
We should get rid of them as much as possible without overcomplicating the code but it will take a while and not an immediate priority to do this completely and will require extensive testing afterwards due to major refactoring.
Some of the work has already been done.

In .eslintrc.json, can be set to "import/no-cycle": ["warn"] to show the cycles.
However when not working on the cycles and before they are removed, this can be temporarily set to off, because it may distract from other warnings.

@KonradHoeffner KonradHoeffner added this to the next milestone Oct 26, 2023
@KonradHoeffner KonradHoeffner self-assigned this Oct 26, 2023
@KonradHoeffner KonradHoeffner modified the milestones: next, later Feb 1, 2024
@KonradHoeffner KonradHoeffner removed their assignment May 10, 2024
@KonradHoeffner
Copy link
Collaborator Author

As a less strict criterion: While we don't have fixed control flow, like model view controller, it is still not good if in every source file / class we call methods of others without rhyme or reason so we should still make sure that there is a somewhat sensible control flow.

@Yagnap
Copy link
Collaborator

Yagnap commented Oct 9, 2024

Could make progress on this in #437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants