Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request_timeout for HTTP/2 #264

Open
lessless opened this issue Feb 18, 2024 · 0 comments
Open

Add request_timeout for HTTP/2 #264

lessless opened this issue Feb 18, 2024 · 0 comments

Comments

@lessless
Copy link

Hey,

I'm dealing with a service that supports only HTTP/2 and dies quite often because of the request_timeout:

* (Finch.Error) request_timeout
    (req 0.4.9) lib/req.ex:978: Req.request!/2
    (grocery_times 0.1.0) lib/grocery_times/sainsburys_product_collector.ex:11: GroceryTimes.SainsburysProductCollector.process/1
    (elixir 1.16.1) lib/enum.ex:1700: Enum."-map/2-lists^map/1-1-"/2
    (elixir 1.16.1) lib/enum.ex:1700: Enum."-map/2-lists^map/1-1-"/2
    (grocery_times 0.1.0) lib/grocery_times/sainsburys_product_collector.ex:6: GroceryTimes.SainsburysProductCollector.process/1
    iex:6: (file)

Per request docs https://hexdocs.pm/finch/Finch.html#request/3 , Finch currently supports request_timeout for HTTP/1, and it will be great to have it for the HTTP/2 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant