-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW FEATURE] - [SafeSnap] Allow to optionally show/select tokens with zero balance #2721
Labels
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bonustrack
added
pinned
and removed
stale
Issues that are old and soon to be closed
labels
Oct 1, 2022
Hey @bonustrack, could you look into this issue? 🙏 Can we add a quick fix for it before the new SafeSnap implementation will be deployed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Briefly describe the feature.
When adding a token transfer to a SafeSnap transaction, allow to optionally show/select tokens with zero balance.
Which problem is this feature trying to solve?
When adding a token transfer to a batch of transactions in SafeSnap, you can only select from tokens which currently have a balance. This is prohibitive for many use-cases which involve proposals that involve tokens that the safe will hold a balance in at execution time.
For example, let's say a DAO has a proposal to use ETH to mint Dai and then transfer some to the Dai to another address.
The Dai does not yet exist in the DAO's account, so the token selection dropdown will not show it, even though the previous call will mint Dai.
What is the expected solution?
Allow users to optionally show and select from a list of tokens with zero balance, along with being able to provide a custom token address.
Given that this list will probably be quite long, it should also include some search function.
How do you currently handle this problem?
I currently handle it by encoding the transfer as a "contract interaction", but this is scary for many users.
Anything else you'd like to mention?
No response
The text was updated successfully, but these errors were encountered: