-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poap-unlock strategy [poap-unlock] #1209
base: master
Are you sure you want to change the base?
Add poap-unlock strategy [poap-unlock] #1209
Conversation
User has one vote if they have any POAPs and zero otherwise. If `eventIds` are specified, than only POAPs of particular event ids are taken into account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paulperegud I see this is same as poap strategy except the check for minimum, you can use our voting validation feature for this, https://docs.snapshot.org/user-guides/strategies/validation-strategies#voting-validation-in-space-settings
Closing this PR for now, feel free to reopen if needed :) |
@ChaituVR I've been the one looking to set this up. Under the link provided, this appears to be for Proposal Validation. Can I ask how this would be applied to a strategy where users with 1, or multiple poaps have the same voting power? |
Ah sorry, this one https://docs.snapshot.org/user-guides/strategies/validation-strategies#validation-strategy-example-basic
|
Apologies for my lack of understanding here. "The Basic validation strategy allows you to use existing Voting Strategies configured for your space or define a custom setup to determine if a user is eligible to create a proposal or cast a vote. " When I go to set this up, all I am seeing is the ability to add which poap events allow a user to be eligible to vote. When a user has both poaps in their wallet, they have x2 voting power. Not seeing where we can limit that scenario to 1 under the link you provided. |
So voting validations are just for yes or no, if validation return true, then using space voting strategies, setup a |
Gitcoin is one of the 10 projects in this vote, and while we support them, it's not going to reflect well if voting requires the use of one of their products as this would reduce voters outside of their community. |
@ChaituVR This PR is something different from ticket option. Yes, both give user just 1 vote, but ticket option requires user to have gitcoin passport. Please reopen (I lack permissions to do that). |
Hey guys we don't require gitcoin validation anymore, you can use basic validation too. in basic validation, you can use Sorry those docs are outdated. @zuz could you update that plz :) #1209 (comment) |
Having trouble getting what you are suggesting to work. Here is what I have under: valdation>basic: { And then additionally ticket with voting power of 1. This still returns a voting power of 2 should a wallet have 2 poaps. Are you able to look at the setup on https://snapshot.org/#/octantapp.eth/settings and see what I am missing here? |
Hey @vpabundance, the setup seems right, and the |
Thank you so much to everyone here who helped, I successfully created and tested the voting. Cheers! |
Adds POAP-unlock voting strategy.
User has one vote if they have any POAPs and zero otherwise. If
eventIds
are specified, than only POAPs of particular event ids are taken into account.