Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected changes in torchaudio.load #25

Closed
mthrok opened this issue Oct 21, 2020 · 2 comments
Closed

Expected changes in torchaudio.load #25

mthrok opened this issue Oct 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@mthrok
Copy link

mthrok commented Oct 21, 2020

Hi

Thanks for using torchaudio. We are overhauling I/O mechanism, and in the future, the signature of torchaudio.load will be slightly changed. The detail can be found pytorch/audio#903

In the following use case, normalization becomes normalize, but the default value will be kept same.

silero-models/utils.py

Lines 29 to 31 in 15d36e4

wav, sr = torchaudio.load(path,
normalization=True,
channels_first=True)

In the upcoming release 0.7.0, (which is expected to happen in about a week), we start issuing warnings about the change, but the code will keep working. In 0.8.0 release (no fixed date yet), the interface will be changed.
Since the default values for normalization/normalize and channels_first are kept same, using wav, sr = torchaudio.load(path) will reduce the maintenance cost.

@snakers4
Copy link
Owner

Hi,

Many thanks for the heads up!
Fixed this 046cccd
Gave it a quick test in the colab, seems to be fine

@mthrok
Copy link
Author

mthrok commented Oct 22, 2020

The change looks good!

@mthrok mthrok closed this as completed Oct 22, 2020
@snakers4 snakers4 added the bug Something isn't working label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants