Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing a string to dontRenameFile, dontUpdateReference etc. is handled unhelpfully #87

Open
ExplodingCabbage opened this issue Apr 22, 2015 · 2 comments

Comments

@ExplodingCabbage
Copy link

Foolishly, one might expect to be able to do something like pass dontRenameFile: 'index.html' to the RevAll constructor, and have its behaviour be equivalent to passing dontRenameFile: ['index.html']. Instead, the string is treated like an array of strings, each of which gets converted to a regex. If the string contains a dot, like 'index.html' does, this will result in all files matching.

This seems like really obviously bad behaviour and from userland it's hard to figure out the cause; it took me quite a while to find my mistake. I figure something more reasonable should happen if I just pass a string as one of these options - even if it's just an error being thrown telling me that I'm an idiot and need to pass an array.

@abahdanovich
Copy link

👍

1 similar comment
@jmcshane
Copy link

jmcshane commented May 13, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants