You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Foolishly, one might expect to be able to do something like pass dontRenameFile: 'index.html' to the RevAll constructor, and have its behaviour be equivalent to passing dontRenameFile: ['index.html']. Instead, the string is treated like an array of strings, each of which gets converted to a regex. If the string contains a dot, like 'index.html' does, this will result in all files matching.
This seems like really obviously bad behaviour and from userland it's hard to figure out the cause; it took me quite a while to find my mistake. I figure something more reasonable should happen if I just pass a string as one of these options - even if it's just an error being thrown telling me that I'm an idiot and need to pass an array.
The text was updated successfully, but these errors were encountered:
Foolishly, one might expect to be able to do something like pass
dontRenameFile: 'index.html'
to theRevAll
constructor, and have its behaviour be equivalent to passingdontRenameFile: ['index.html']
. Instead, the string is treated like an array of strings, each of which gets converted to a regex. If the string contains a dot, like'index.html'
does, this will result in all files matching.This seems like really obviously bad behaviour and from userland it's hard to figure out the cause; it took me quite a while to find my mistake. I figure something more reasonable should happen if I just pass a string as one of these options - even if it's just an error being thrown telling me that I'm an idiot and need to pass an array.
The text was updated successfully, but these errors were encountered: