Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect revisioning in a corner case #162

Open
inian opened this issue Dec 3, 2016 · 4 comments
Open

Incorrect revisioning in a corner case #162

inian opened this issue Dec 3, 2016 · 4 comments

Comments

@inian
Copy link
Contributor

inian commented Dec 3, 2016

I have a JS file with code like
this.parentNode.classList.add("overlay")

and another JS file called overlay.js

The code in the first file incorrectly gets changed to
this.parentNode.classList.add("/overlay.sdfsdfs")

The overlay string is not a reference to the overlay.js file and should not be renamed. Should extensionless javascript be supported in the first place?

@liumanwei
Copy link

I also have the same problem

@smozely
Copy link

smozely commented Mar 23, 2017

This bit me too on the upgrade, seems like it shouldn't be handling cases where there is no extension. We have a JS file review.js and the number of times the text review comes up in other JS files is pretty high, all used in contexts where it is not referencing a JS file

@artuska
Copy link

artuska commented Apr 30, 2017

+1. Please, just add an option to replace only strings with the file extension.

@jackrugile
Copy link

+1 trying to get this one figured out as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants