Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dontRenameFile not working reliable #158

Open
devshack opened this issue Oct 10, 2016 · 1 comment
Open

dontRenameFile not working reliable #158

devshack opened this issue Oct 10, 2016 · 1 comment

Comments

@devshack
Copy link

Hey,

in a current project the option "dontRenameFile" is not 100% reliable.

My current development structure is like this:

/dist/
/dist/index.html
/dist/project.appcache
/dist/templates/
/dist/templates/header.tmpl.html (etc.)
/dist/assets/ (images, css, js etc)

My task:

gulp.task('revision', () => {

  return gulp.src( './dist/**' )
    .pipe( RevAll.revision({ 
        dontRenameFile: [/\.html$/]
    }
    ))
    .pipe( gulp.dest('dist-cdn') );

});

Everything works as expected so far - all *.html files are untouched, all assets (css, img, js) are processed correctly (e.g. project.appcache -> project.f439fheuf3.appcache).

The problem is within the file project.appcache. All *.html files are untouched, as mentioned above - but the content of the .appache file is as follows:

CACHE MANIFEST

# What to cache?
CACHE:
templates/*
assets/*
index.0ba0d94a.html

NETWORK:
*

RevAll has processed the containing string "index.html" to "index.0ba0d94a.html" ... which is not correct or expected.

@maxstoyanov
Copy link

maxstoyanov commented Feb 21, 2017

If we have the same issue then try this:
dontUpdateReference: ['.html']

Linked to #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants